Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(payment_methods): remove duplicated pm entry creation during network token payment when customer acceptance is passed #6498

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(payment_methods): remove duplicated pm entry creation during network token payment when customer acceptance is passed #6498

wants to merge 2 commits into from

Conversation

prasunna09
Copy link
Contributor

@prasunna09 prasunna09 commented Nov 6, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

remove duplicated pm entry creation during network token payment when customer acceptance is passed in CIT repeat flow (saved card flow)

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@prasunna09 prasunna09 added the C-bug Category: Bug label Nov 6, 2024
@prasunna09 prasunna09 self-assigned this Nov 6, 2024
@prasunna09 prasunna09 requested review from a team as code owners November 6, 2024 19:07
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Nov 6, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/core/payments/tokenization.rs  93% smaller
  crates/router/src/core/payments/operations/payment_response.rs  0% smaller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aprabhat19 Aprabhat19 Awaiting requested review from Aprabhat19

@ShankarSinghC ShankarSinghC Awaiting requested review from ShankarSinghC

At least 2 approving reviews are required to merge this pull request.

Assignees

@prasunna09 prasunna09

Labels
C-bug Category: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@prasunna09